test: refactor test-dgram-address.js#11271
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Feb 9, 2017
ContributorAuthor
cjihrig commented Feb 10, 2017
- separate the IPv4 and IPv6 tests using block scopes - use common.mustCall() and arrow functions for callbacks - add coverage for case where address() throws PR-URL: nodejs#11271 Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
- separate the IPv4 and IPv6 tests using block scopes - use common.mustCall() and arrow functions for callbacks - add coverage for case where address() throws PR-URL: nodejs#11271 Reviewed-By: James M Snell <[email protected]>
2 tasks
Member
jasnell commented Mar 9, 2017
Needs backport PRs if it should land on v6 or v4 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.mustCall()and arrow functions for callbacksaddress()throwsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test