test: consolidating buffer.read()#11297
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Feb 10, 2017
| // attempt to overflow buffers, similar to previous bug in array buffers | ||
| assert.throws(() => Buffer.allocUnsafe(8).readFloatLE(0xffffffff), | ||
| RangeError); |
Contributor
There was a problem hiding this comment.
Can we check the actual errors itself, so that we can avoid problems like #11162?
Member
There was a problem hiding this comment.
I'm in favor of this, but since this PR is a straightforward re-organization of the tests and not actual changes/enhancements, I'd be OK with that happening in a subsequent PR.
Member
Trott commented Feb 14, 2017
Member
jasnell commented Feb 16, 2017
one failure in ci is unrelated |
jasnell pushed a commit that referenced this pull request Feb 17, 2017
PR-URL: #11297 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
jasnell commented Feb 17, 2017
landed in 8a25e31 |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
PR-URL: nodejs#11297 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
PR-URL: #11297 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Member
jasnell commented Mar 7, 2017
would need a backport PR to land on v4 |
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11297 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11297 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Merging buffer-read test present in
test-buffer-alloc.jstotest-buffer-read.jsfile