benchmarks: add dgram bind(+/- params) benchmark

[vsemozhetbyt]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

benchmarks, dgram

This is a benchmark for this case requsted here.

An output from a separate run:
Before fix:

dgram\bind-params.js address="true" port="true" n=10000: 122,075.0274095059 dgram\bind-params.js address="false" port="true" n=10000: 101,787.33470373016 dgram\bind-params.js address="false" port="false" n=10000: 101,181.97238774327 

After fix:

dgram\bind-params.js address="true" port="true" n=10000: 123,071.85933260615 dgram\bind-params.js address="false" port="true" n=10000: 123,060.85776592833 dgram\bind-params.js address="false" port="false" n=10000: 124,657.66978190755 

An output from a comparing run:

 improvement confidence p.value dgram\\bind-params.js address="false" port="false" n=10000 25.09 % *** 2.923931e-40 dgram\\bind-params.js address="false" port="true" n=10000 19.35 % *** 1.138406e-32 dgram\\bind-params.js address="true" port="true" n=10000 -0.39 % 4.534955e-01 

[vsemozhetbyt]

//cc @nodejs/benchmarking

[jasnell]

@mscdex

[mscdex]

Perhaps this section can be omitted entirely (e.g. use address === undefined && port !== undefined for the below conditional)?

[vsemozhetbyt]

So, in this case, the last else should be replaced by else if (address === undefined && port === undefined), should not it?

[mscdex]

That's basically what I was suggesting, yes. Except perhaps it would be better to reverse the checks to match the same order used in the first conditional:

} else if (port !== undefined && address === undefined){

or we could just remove the middle section entirely and it should still work as-is:

} else if (port !== undefined){

[mscdex]

I think this should just use the literal value inline, since it's the only place the variable is used.

[vsemozhetbyt]

OK. I've just linted with no-magic-numbers, but this is not Node.js mandatory rule. I will fix it.

[vsemozhetbyt]

@mscdex Fixed (the results of comparing updated).

[vsemozhetbyt]

@mscdex@jasnell Could this be landed?

[mscdex]

Lint: https://ci.nodejs.org/job/node-test-linter/7197/

[mscdex]

Linter shows green, LGTM.

[addaleax]

Landed in 1162e28