build: fix building with ninja on linux#11348
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
ContributorAuthor
kenany commented Feb 13, 2017
/cc @Fishrock123, @gibfahn (to test on OS X?). @sam-github (who also had this issue) |
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed to `ninja` on OS X which places it outside of that directory. Furthermore, the expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`. This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the correct values for `ninja` on Linux specifically. Fixes: nodejs#9861
bnoordhuis approved these changes Feb 13, 2017
Contributor
sam-github commented Feb 13, 2017
Built on Linux for me. Doing some rebuilding to see if ninja is faster than make, LGTM |
sam-github approved these changes Feb 13, 2017
Contributor
Fishrock123 commented Feb 13, 2017
Seems to work fine for me on macOS 10.10.5 |
gibfahn approved these changes Feb 14, 2017
Member
gibfahn left a comment
gibfahn left a comment There was a problem hiding this comment.
Works for me on macOS 10.12 (Sierra).
Member
jasnell commented Feb 16, 2017
CI only to make sure there's no impact on regular build: https://ci.nodejs.org/job/node-test-pull-request/6454/ |
jasnell approved these changes Feb 16, 2017
jasnell pushed a commit that referenced this pull request Feb 17, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed to `ninja` on OS X which places it outside of that directory. Furthermore, the expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`. This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the correct values for `ninja` on Linux specifically. PR-URL: #11348Fixes: #9861 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Feb 17, 2017
Landed in 70afe9d |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed to `ninja` on OS X which places it outside of that directory. Furthermore, the expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`. This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the correct values for `ninja` on Linux specifically. PR-URL: nodejs#11348Fixes: nodejs#9861 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
On Linux, `ninja` appears to place `libv8_base.a` inside `OBJ_DIR`, as opposed to `ninja` on OS X which places it outside of that directory. Furthermore, the expected `OBJ_DIR` value (`obj.target/`) is actually just `obj/` for `ninja`. This patch solves both of these issues by setting `OBJ_DIR` and `V8_BASE` to the correct values for `ninja` on Linux specifically. PR-URL: #11348Fixes: #9861 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Member
jasnell commented Mar 7, 2017
needs a backport PR to land on v6 or v4 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux,
ninjaappears to placelibv8_base.ainsideOBJ_DIR, as opposed toninjaon OS X which places it outside of that directory. Furthermore, the expectedOBJ_DIRvalue (obj.target/) is actually justobj/forninja. This patch solves both of these issues by settingOBJ_DIRandV8_BASEto thecorrect values for
ninjaon Linux specifically.Fixes: #9861
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem
build