dns: avoid use of arguments#11359
Closed
dns: avoid use of arguments #11359
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
ChALkeR commented Feb 13, 2017
Does this have any effect on benchmarks? |
lpinca approved these changes Feb 14, 2017
MemberAuthor
jasnell commented Feb 14, 2017
CI: https://ci.nodejs.org/job/node-test-pull-request/6417/ |
targos approved these changes Feb 14, 2017
Member
targos left a comment
targos left a comment There was a problem hiding this comment.
LGTM with a suggestion (untested perf-wise)
| if(asyncCallback.immediately){ | ||
| // The API already returned, we can invoke the callback immediately. | ||
| callback.apply(null,arguments); | ||
| callback.apply(null,args); |
MemberAuthor
There was a problem hiding this comment.
Spread arguments still appear to be quite a bit slower according to benchmarks. Even the ...args has mixed results that I haven't quite been able to track down the cause of.
| for(vari=0;i<arguments.length;++i) | ||
| args[i+1]=arguments[i]; | ||
| args.unshift(callback); | ||
| process.nextTick.apply(null,args); |
Member
There was a problem hiding this comment.
And process.nextTick(callback, ...args)
jasnell added a commit that referenced this pull request Feb 15, 2017
PR-URL: #11359 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]
MemberAuthor
jasnell commented Feb 15, 2017
Landed e36d0d3 |
2 tasks
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
PR-URL: nodejs#11359 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
PR-URL: #11359 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-explanatory ... avoid unnecessary uses of arguments
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dns