Skip to content

url: fix handling of ? in URLSearchParams creation#11372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimothyGu wants to merge 2 commits into from
Closed

url: fix handling of ? in URLSearchParams creation #11372

TimothyGu wants to merge 2 commits into from

Conversation

@TimothyGu
Copy link
Member

@TimothyGuTimothyGu commented Feb 14, 2017•
edited
Loading

Fixes: #11093
Ref: whatwg/url#248

CI: https://ci.nodejs.org/job/node-test-pull-request/6401/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 14, 2017
@TimothyGu
Copy link
MemberAuthor

TimothyGu commented Feb 17, 2017

Landed in fa41dd1.

@TimothyGuTimothyGu deleted the gh-11093 branch February 17, 2017 05:12
TimothyGu added a commit that referenced this pull request Feb 17, 2017
@TimothyGu
url: fix handling of ? in URLSearchParams creation
fa41dd1
PR-URL: #11372Fixes: #11093 Ref: whatwg/url#248 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
@TimothyGu
url: fix handling of ? in URLSearchParams creation
5f10827
PR-URL: nodejs#11372Fixes: nodejs#11093 Ref: whatwg/url#248 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
@italoacasasitaloacasas mentioned this pull request Feb 25, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimothyGu@jasnell@joyeecheung@nodejs-github-bot