Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
test, url: URLSearchParams splits across lines#11428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
watilde commented Feb 16, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`.
jasnell approved these changes Feb 16, 2017
Member
jasnell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Member
jasnell commented Feb 16, 2017
TimothyGu approved these changes Feb 17, 2017
joyeecheung approved these changes Feb 17, 2017
targos approved these changes Feb 17, 2017
Member
targos commented Feb 17, 2017
targos pushed a commit to targos/node that referenced this pull request Feb 18, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
targos commented Feb 18, 2017
Landed in 8629b33 |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
This was referenced Nov 29, 2023
This was referenced Dec 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testIssues and PRs related to the tests. whatwg-urlIssues and PRs related to the WHATWG URL implementation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member methods of URLSearchParams should split across multiple lines with
util.inspectdepending on an optionbreakLength.This test increases the coverage of internal/url.js:
The following line will be called:
node/lib/internal/url.js
Lines 1057 to 1059 in 82ddf96
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
test,url