Skip to content

Conversation

@watilde
Copy link
Contributor

@watildewatilde commented Feb 16, 2017

The member methods of URLSearchParams should split across multiple lines with util.inspect depending on an option breakLength.

This test increases the coverage of internal/url.js:

The following line will be called:

Checklist
  • make -j4 test (UNIX) passes
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,url

The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 16, 2017
Copy link
Member

@jasnelljasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jasnell
Copy link
Member

@mscdexmscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 16, 2017
@targos
Copy link
Member

targos pushed a commit to targos/node that referenced this pull request Feb 18, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

Landed in 8629b33

@targostargos closed this Feb 18, 2017
@watildewatilde deleted the url-breakLn branch February 18, 2017 16:33
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
The member methods of URLSearchParams should split across multiple lines with `util.inspect` depending on an option `breakLength`. PR-URL: nodejs#11428 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@italoacasasitaloacasas mentioned this pull request Feb 25, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@watilde@jasnell@targos@TimothyGu@joyeecheung@mscdex@nodejs-github-bot