url: use hasIntl instead of try-catch#11571
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the url 
jasnell approved these changes Feb 27, 2017
Contributor
JacksonTian commented Feb 27, 2017
LGTM |
TimothyGu approved these changes Feb 27, 2017
Member
Slight nit in commit message: IMO "internal modules" sounds better than "lib codes". Otherwise LGTM. |
cjihrig approved these changes Feb 27, 2017
Member
gibfahn commented Feb 27, 2017
Not entirely sure what happened with linuxone in that last CI, rerunning: CI 2: https://ci.nodejs.org/job/node-test-commit/8137/ EDIT: Passed on rerun |
lpinca approved these changes Feb 27, 2017
MemberAuthor
watilde commented Feb 28, 2017
I will update the commit message to replace |
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not.
watildeforce-pushed the feature/url-hasIntl branch from 15cf5ba to 50e7e6eCompare
addaleax approved these changes Mar 1, 2017
MemberAuthor
watilde commented Mar 3, 2017
jasnell pushed a commit that referenced this pull request Mar 4, 2017
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: #11571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
Member
jasnell commented Mar 4, 2017
Landed in cccc6d8 |
addaleax pushed a commit that referenced this pull request Mar 5, 2017
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: #11571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: #11571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jackson Tian <[email protected]>MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: #11571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: nodejs/node#11571 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jackson Tian <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the other lib codes, we should use
process.binding('config').hasIntlinstead oftry-catchto make sureicuis bonded or not.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url