tools: fix lint issue in doctool#11658
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
Member
addaleax commented Mar 2, 2017
Doesn’t the linter catch issues in |
addaleax approved these changes Mar 2, 2017
lpinca approved these changes Mar 2, 2017
ContributorAuthor
silverwind commented Mar 2, 2017
It does, but I simply forgot to run it after my latest change in that PR. Running |
jasnell approved these changes Mar 2, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM. Let's fast track this to unbreak CI
Member
jasnell commented Mar 2, 2017
jasnell pushed a commit that referenced this pull request Mar 2, 2017
PR-URL: #11658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 2, 2017
Landed in 172be50 |
ContributorAuthor
silverwind commented Mar 2, 2017
Thanks @jasnell. For the record, the issue happened because my workflow on that PR was basically I'll have to remember to actually run tests on that type of change too, because tests partially cover the doctool |
Member
jasnell commented Mar 2, 2017
It's all good. I just did a lint check on this particular PR. You make want to do a full CI run just to make sure that everything else is still good. |
ContributorAuthor
silverwind commented Mar 2, 2017
|
Contributor
evanlucas commented Mar 7, 2017
This is not landing cleanly on v7.x-staging. Mind submitting a backport PR? |
ContributorAuthor
silverwind commented Mar 7, 2017
silverwind added a commit to silverwind/node that referenced this pull request Mar 8, 2017
PR-URL: nodejs#11658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
PR-URL: nodejs#11658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Apr 17, 2017
do we want to backport to v6.x? |
ContributorAuthor
silverwind commented May 16, 2017
Backport in #13054 |
gibfahn pushed a commit that referenced this pull request May 16, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
silverwind added a commit to silverwind/node that referenced this pull request May 18, 2017
PR-URL: nodejs#11658 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jun 17, 2017
PR-URL: nodejs#11658 Backport-PR-URL: nodejs#13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a lint issue introduced in #11167.
cc: @jasnell