util: fix inspecting symbol key in string#11672
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the util 
ContributorAuthor
barinali commented Mar 3, 2017
@cjihrig sorry for that. I've added a test case right now. I hope it would be enough. |
jasnell approved these changes Mar 3, 2017
lpinca approved these changes Mar 3, 2017
cjihrig approved these changes Mar 6, 2017
Member
Member
lpinca commented Mar 6, 2017
@barinali can you please run |
ContributorAuthor
barinali commented Mar 6, 2017
@lpinca I'm on it right now. |
ContributorAuthor
barinali commented Mar 6, 2017
@lpinca I've fixed issues. |
Member
lpinca commented Mar 6, 2017
Member
lpinca commented Mar 6, 2017
Landed in d0b93c9. |
lpinca pushed a commit that referenced this pull request Mar 6, 2017
PR-URL: #11672 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11672 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
evanlucas added a commit that referenced this pull request Mar 8, 2017
evanlucas added a commit that referenced this pull request Mar 8, 2017
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 16, 2017
Notable changes: * doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs/node#11676 * tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs/node#7360 * util: fix inspecting symbol key in string (Ali BARIN) nodejs/node#11672 PR-URL: nodejs/node#11745 Signed-off-by: Ilkka Myller <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Notable changes: * doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs#11676 * tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs#7360 * util: fix inspecting symbol key in string (Ali BARIN) nodejs#11672 PR-URL: nodejs#11745
Contributor
MylesBorins commented Apr 17, 2017
The test fails when cherry-picked to v6.x Please backport if it is applicable |
barinali added a commit to barinali/node that referenced this pull request May 7, 2017
PR-URL: nodejs#11672 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ContributorAuthor
barinali commented May 7, 2017
@MylesBorins tests ( |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to use type check to avoid checking Symbols in numeric conditions.
Fixes: #11659
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)