(v7.x backport) child_process: fix deoptimizing use of arguments#11748
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removed or fixed use of arguments in execFile(), normalizeExecArgs(), and normalizeSpawnArguments(). Refs: #10323 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=6010
nodejs-github-bot added child_process 
vsemozhetbyt changed the title 
ContributorAuthor
This is my first backport using the proposed guide. Please, correct me if I've done something wrong. #8312 was the cause of the conflict, so I've just removed the bit from it. |
3 tasks
Member
jasnell commented Mar 8, 2017
jasnell approved these changes Mar 16, 2017
jasnell pushed a commit that referenced this pull request Mar 16, 2017
Removed or fixed use of arguments in execFile(), normalizeExecArgs(), and normalizeSpawnArguments(). Refs: #10323 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=6010 Backport-Of: #11535 PR-URL: #11748 Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 16, 2017
Landed in 5b1d61c |
Contributor
MylesBorins commented Apr 17, 2017
do we want to backport to v6.x? |
Contributor
MylesBorins commented May 15, 2017
ping |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
child_process, benchmark
Backport of #11535