test: fix flaky test-domain-abort-on-uncaught#11817
Closed
+0 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added domain 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. Fixes: nodejs#11814
Trott changed the title 
MemberAuthor
Trott commented Mar 12, 2017
MemberAuthor
Trott commented Mar 12, 2017
Stress test of master (should show failures): https://ci.nodejs.org/job/node-stress-single-test/1119/nodes=armv8-ubuntu1404/console Stress test of this PR (should be green): https://ci.nodejs.org/job/node-stress-single-test/1120/nodes=armv7-ubuntu1404/console |
MemberAuthor
Trott commented Mar 12, 2017
Whoops, ran the initial stress test on the wrong architecture. Stress test again on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test/1122/nodes=armv7-ubuntu1404/console Stress test on this PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1123/nodes=armv7-ubuntu1404/console |
MemberAuthor
Trott commented Mar 12, 2017
Amping up the stress test a bit more to 16 parallel processes. Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1127/nodes=armv7-ubuntu1404/console This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1128/nodes=armv7-ubuntu1404/console |
MemberAuthor
Trott commented Mar 12, 2017
Amping up the stress test a bit more to 32 parallel processes. Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1129/nodes=armv7-ubuntu1404/console This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1130/nodes=armv7-ubuntu1404/console |
MemberAuthor
Trott commented Mar 12, 2017
(Current master is failing the stress test, this PR is passing it.) |
cjihrig approved these changes Mar 13, 2017
gibfahn approved these changes Mar 13, 2017
watilde approved these changes Mar 13, 2017
santigimeno approved these changes Mar 13, 2017
hiroppy approved these changes Mar 13, 2017
jasnell approved these changes Mar 13, 2017
2 tasks
Member
jasnell commented Mar 15, 2017
New CI since there was a failure on Windows: https://ci.nodejs.org/job/node-test-pull-request/6844/ |
jasnell pushed a commit that referenced this pull request Mar 16, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: #11817Fixes: #11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 16, 2017
Landed in 5e3d536 |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: nodejs#11817Fixes: nodejs#11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: nodejs#11817Fixes: nodejs#11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: #11817Fixes: #11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: #11817Fixes: #11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: nodejs/node#11817Fixes: nodejs/node#11814 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.
Fixes: #11814
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test domain