errors: add duplicate symbol checking in E() and increase coverage#11829
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the errors 
mscdex reviewed Mar 13, 2017
Contributor
There was a problem hiding this comment.
FWIW you could move the arguments to new (indented) lines to avoid new RegExp() and string concatenation:
assert.throws(()=>errors.E('TEST_ERROR_USED_SYMBOL'),/^AssertionError:Errorsymbol:TEST_ERROR_USED_SYMBOLwasused\.$/);
Contributor
mscdex commented Mar 13, 2017
The first line of the commit message exceeds 50 characters. |
DavidCai1111force-pushed the errors/check-used-sym branch 3 times, most recently from 14348ce to 1e4ab50Compare
MemberAuthor
DavidCai1111 commented Mar 13, 2017
@mscdex Thanks for reviewing. Updated, PTAL. |
mscdex reviewed Mar 13, 2017
Contributor
There was a problem hiding this comment.
The period should be escaped to avoid matching any character instead of a literal period.
MemberAuthor
There was a problem hiding this comment.
Oh...Sorry for forgetting that. Updated.
DavidCai1111force-pushed the errors/check-used-sym branch from 1e4ab50 to ffbd3a3CompareDavidCai1111 changed the title 
targos reviewed Mar 13, 2017
lib/internal/errors.js Outdated
Member
There was a problem hiding this comment.
maybe "was used before" or "was already used" ?
MemberAuthor
There was a problem hiding this comment.
@targos Thanks for reviewing. Changed to "was already used", PTAL.
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors.
DavidCai1111force-pushed the errors/check-used-sym branch from ffbd3a3 to a907059CompareContributor
mscdex commented Mar 13, 2017
jasnell approved these changes Mar 13, 2017
cjihrig approved these changes Mar 13, 2017
targos approved these changes Mar 14, 2017
fhinkel approved these changes Mar 15, 2017
Member
fhinkel commented Mar 15, 2017
Thanks. Landed in b5eccc4 |
fhinkel pushed a commit that referenced this pull request Mar 15, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: #11829 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: nodejs#11829 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: nodejs#11829 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Contributor
MylesBorins commented Apr 18, 2017
Doesn't land on v6.x afaict. If it does land somewhere else in the tree lmk |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add duplicate error symbol checking in
E()to avoid potential confusing result.Improve coverage of
internal/errors.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors