lib: removed unused msg parameter in debug_agent#11833
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Mar 13, 2017
Member
gibfahn commented Mar 13, 2017
Minor nit: could you change See the Contributing Guidelines for more info. Someone can do this on landing if you don't have time. |
danbev approved these changes Mar 13, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused.
cjihrig approved these changes Mar 13, 2017
hiroppy approved these changes Mar 14, 2017
Contributor
JacksonTian commented Mar 14, 2017
LGTM |
Member
hiroppy commented Mar 14, 2017
fhinkel approved these changes Mar 15, 2017
Member
Thanks. Landed in 5bd1642 |
fhinkel pushed a commit that referenced this pull request Mar 15, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: #11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: nodejs#11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: nodejs#11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: #11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: #11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: nodejs/node#11833 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
This was referenced Mar 7, 2020
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib