test: improve readline test coverage for tty

[claudiorodriguez]

Adds the following tests for tty readline:

• go to beginning and end of line
• wordLeft
• wordRight
• deleteWordLeft
• deleteWordRight

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test

[Fishrock123]

So, to be clear... this test file runes with stdio as pipes, not ttys.

By the look of the code this doesn't actually touch TTY at all, maybe that should be removed form the commit message?

[Fishrock123]

CI: https://ci.nodejs.org/job/node-test-pull-request/7057/

[claudiorodriguez]

@Fishrock123 sorry, what I meant is that it improves coverage for readline when going through _ttyWrite, that is, when the Interface is constructed with terminal: true. The commit message might cause confusion with the tty module, I can definitely remove it.

[Fishrock123]

if _ttyWrite fits into the message that might be ideal?

[claudiorodriguez]

@Fishrock123 sure thing, I'll wait for the CI run to complete then fix that

[claudiorodriguez]

@Fishrock123 completely forgot about this, does the new message seem alright to you?

[BridgeAR]

LG if CI is green. This needs a rebase though

[BridgeAR]

@claudiorodriguez would you be so kind and rebase this?

[claudiorodriguez]

@BridgeAR rebased, cheers
New CI run: https://ci.nodejs.org/job/node-test-pull-request/9957/

[BridgeAR]

Still LGTM but it would be nice if my two comments would be addressed before landing.

[BridgeAR]

Please use common.mustCall instead of called in all of these functions.

[BridgeAR]

Super tiny nit - would you be so kind and upper case all beginnings of comments?

[claudiorodriguez]

@BridgeAR comments addressed, cheers

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/10149/

[BridgeAR]

Landed in 7a95392