build: avoid passing kill empty input in Makefile#12158
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
Trott approved these changes Apr 1, 2017
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Much better. Thanks for this. LGTM if CI is green.
richardlau approved these changes Apr 1, 2017
jasnell approved these changes Apr 3, 2017
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: nodejs#12158 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas commented Apr 10, 2017
cc @gibfahn |
MemberAuthor
gibfahn commented Apr 11, 2017
v7.x backport: #12337 |
gibfahn added a commit to gibfahn/node that referenced this pull request May 22, 2017
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: nodejs#12158
This was referenced Jun 15, 2017
MemberAuthor
gibfahn commented Jun 17, 2017
Should land after #11246 |
gibfahn added a commit that referenced this pull request Jun 18, 2017
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: #12158 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn added a commit that referenced this pull request Jun 20, 2017
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: #12158 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: #12158 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
xargs -ron some platforms andxargson others doesn't work,we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.
I ran into this as I'm on macOS, but have a GNU xargs (from
brew install findutils).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build
cc/ @Trott @nodejs/build
EDIT: CI: https://ci.nodejs.org/job/node-test-commit/8825/ - CI is green