build: don't test addons-napi twice#12201
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gibfahn added build 
nodejs-github-bot added the build 
thefourtheye approved these changes Apr 4, 2017
bnoordhuis approved these changes Apr 4, 2017
danbev approved these changes Apr 4, 2017
richardlau approved these changes Apr 4, 2017
addaleax approved these changes Apr 4, 2017
cjihrig approved these changes Apr 4, 2017
jasnell approved these changes Apr 4, 2017
digitalinfinity approved these changes Apr 6, 2017
The addons-napi testsuite is already included in $(CI_NATIVE_SUITES), so we don't need to manually specify it in the test-ci target as well. PR-URL: nodejs#12201 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addons-napi testsuite is already included in $(CI_NATIVE_SUITES), so
we don't need to manually specify it in the test-ci target as well.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
CI: https://ci.nodejs.org/job/node-test-commit/8866/EDIT: Windows failed
CI 2: https://ci.nodejs.org/job/node-test-commit/8867/
CI 3: https://ci.nodejs.org/job/node-test-commit/8939/
CI 4: https://ci.nodejs.org/job/node-test-commit/8984/