build: create test_addons function#12204
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the build 
danbev commented Apr 4, 2017
Makefile Outdated
There was a problem hiding this comment.
Btw, @Fishrock123 recently asked on IRC whether we could parallelize addon building… any chance there’s an easy way to do this in make?
There was a problem hiding this comment.
Not off the top of my head (only know about the -j flag to make for that) but I'll take a look and see what options exist.
There was a problem hiding this comment.
@addaleax I've added a commit now for this. Let me know what you think.
There was a problem hiding this comment.
I created #12230 since making the building of addons parallel does not really relate to this PR. I'll remove also remove that commit from this PR.
danbev commented Apr 4, 2017
I windows failure looks unrelated to this commit: not ok 32 parallel/test-cli-syntax --- duration_ms: 3.104 severity: fail stack: |- assert.js:82 throw new assert.AssertionError({ ^ AssertionError: 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o === 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:127:12 at Array.forEach (native) at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:123:20 at Array.forEach (native) at Object.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:122:19) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) at Module.load (module.js:516:32) at tryModuleLoad (module.js:466:12) at Function.Module._load (module.js:458:3) |
Trott commented Apr 4, 2017
The Windows failure was a problem on the master branch and has since been fixed. |
danbev commented Apr 4, 2017
Thanks for that, I'll rebase and rerun Ci. |
danbevforce-pushed the addons_test_function branch from 476b1cc to 1bd2f8eComparedanbev commented Apr 4, 2017
danbev commented Apr 4, 2017
mscdex added addons 
test/addons/.buildstamp and test/addons-napi/.buildstamp targets are very similar except that they operate on different directories. This commit extracts the common parts into a function to avoid the duplication.
danbevforce-pushed the addons_test_function branch from fff95d6 to 1fb7d60Comparedanbev commented Apr 5, 2017
Closing in favour of #12231 |
refack added the embedding 9 participants
test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build