src: use option parser for expose_internals

lib/internal/bootstrap_node.js

@@ -510,11 +510,9 @@
 returnNativeModule._source.hasOwnProperty(id);
 };
 
-constEXPOSE_INTERNALS=process.execArgv.some(function(arg){
-returnarg.match(/^--expose[-_]internals$/);
-});
+constconfig=process.binding('config');
 
-if(EXPOSE_INTERNALS){
+if(config.exposeInternals){
 NativeModule.nonInternalExists=NativeModule.exists;
 
 NativeModule.isInternal=function(id){

src/node.cc

@@ -214,6 +214,12 @@ bool config_preserve_symlinks = false;
 // Set in node.cc by ParseArgs when --redirect-warnings= is used.
 std::string config_warning_file; // NOLINT(runtime/string)
 
+// Set in node.cc by ParseArgs when --expose-internals or --expose_internals is
+// used.
+// Used in node_config.cc to set a constant on process.binding('config')
+// that is used by lib/internal/bootstrap_node.js
+bool config_expose_internals = false;
+
 bool v8_initialized = false;
 
 // process-relative uptime base, initialized at start-up
@@ -3277,6 +3283,7 @@ void SetupProcessObject(Environment* env,
  READONLY_PROPERTY(process, "_forceRepl", True(env->isolate()));
  }
 
+ // -r, --require
  if (!preload_modules.empty()){
  Local<Array> array = Array::New(env->isolate());
  for (unsigned int i = 0; i < preload_modules.size(); ++i){
@@ -3296,10 +3303,12 @@ void SetupProcessObject(Environment* env,
  READONLY_PROPERTY(process, "noDeprecation", True(env->isolate()));
  }
 
+ // --no-warnings
  if (no_process_warnings){
  READONLY_PROPERTY(process, "noProcessWarnings", True(env->isolate()));
  }
 
+ // --trace-warnings
  if (trace_warnings){
  READONLY_PROPERTY(process, "traceProcessWarnings", True(env->isolate()));
  }
@@ -3784,7 +3793,7 @@ static void ParseArgs(int* argc,
 #endif
  } else if (strcmp(arg, "--expose-internals") == 0 ||
  strcmp(arg, "--expose_internals") == 0){
-// consumed in js
+config_expose_internals = true;
  } else if (strcmp(arg, "--") == 0){
  index += 1;
  break;

src/node_config.cc

@@ -58,6 +58,9 @@ void InitConfig(Local<Object> target,
  .ToLocalChecked();
  target->DefineOwnProperty(env->context(), name, value).FromJust();
  }
+
+ if (config_expose_internals)
+ READONLY_BOOLEAN_PROPERTY("exposeInternals");
 } // InitConfig
 
 } // namespace node

src/node_internals.h

@@ -65,6 +65,12 @@ extern std::string openssl_config;
 // that is used by lib/module.js
 extern bool config_preserve_symlinks;
 
+// Set in node.cc by ParseArgs when --expose-internals or --expose_internals is
+// used.
+// Used in node_config.cc to set a constant on process.binding('config')
+// that is used by lib/internal/bootstrap_node.js
+extern bool config_expose_internals;
+
 // Set in node.cc by ParseArgs when --redirect-warnings= is used.
 // Used to redirect warning output to a file rather than sending
 // it to stderr.

test/parallel/test-internal-modules-expose.js

@@ -3,5 +3,9 @@
 
 require('../common');
 constassert=require('assert');
+constconfig=process.binding('config');
+
+console.log(config,process.argv);
 
 assert.strictEqual(typeofrequire('internal/freelist').FreeList,'function');
+assert.strictEqual(config.exposeInternals,true);