buffer: use slightly faster NaN check#12286
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added buffer 
nodejs-github-bot added the buffer 
TimothyGu approved these changes Apr 8, 2017
lpinca approved these changes Apr 8, 2017
cjihrig approved these changes Apr 8, 2017
aqrln reviewed Apr 8, 2017
Contributor
There was a problem hiding this comment.
Nit: inconsistent var and const usage. I suppose it was copied from benchmark/buffers/buffer-indexof.js.
jasnell approved these changes Apr 11, 2017
mscdexforce-pushed the buffer-faster-isnan branch from 8d08d6e to ab5b9eeCompare
mscdexforce-pushed the buffer-faster-isnan branch from ab5b9ee to 667ea63Compare
ContributorAuthor
mscdex commented Apr 14, 2017
One last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/7411/ |
PR-URL: nodejs#12286 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
4 tasks
mscdexforce-pushed the buffer-faster-isnan branch from 667ea63 to e0f0f26Compareevanlucas pushed a commit that referenced this pull request Apr 25, 2017
PR-URL: #12286 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
PR-URL: #12286 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
PR-URL: #12286 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gibfahn added baking-for-lts 
Member
gibfahn commented May 15, 2017
@mscdex should this be backported to v6.x? |
ContributorAuthor
mscdex commented May 15, 2017
@gibfahn I'm pretty sure it's applicable performance-wise (even back to the v0.10 days) from what I remember. |
MylesBorins removed the baking-for-lts Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance results:
CI: https://ci.nodejs.org/job/node-test-pull-request/7287/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)