url: remove javascript URL special case#12331
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v4.x whatwg-url 
TimothyGu approved these changes Apr 11, 2017
ContributorAuthor
watilde commented Apr 11, 2017
targos approved these changes Apr 11, 2017
ContributorAuthor
watilde commented Apr 11, 2017
The windows-fanned failure looks unrelated. |
jasnell approved these changes Apr 11, 2017
cjihrig approved these changes Apr 11, 2017
ContributorAuthor
watilde commented Apr 12, 2017
Landed in eb0492d. Thanks! |
watilde added a commit that referenced this pull request Apr 12, 2017
Fixes: #11485 PR-URL: #12331 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #11485
Checklist
make -j4 test(UNIX)Affected core subsystem(s)
url