test: add test-benchmark-crypto

[Trott]

Add minimal test for crypto benchmarks. It makes sure that they can run
without returning an error code.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

test benchmark crypto

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/7394/

[jasnell]

Lgtm. There's a fair amount of duplication across these benchmark tests. It may be worthwhile to explore a utility function in common.

[Trott]

Some timeouts and I probably need to add some hasCrypto check to the test too. Revisions coming soon...

[Trott]

It may be worthwhile to explore a utility function in common.

Perhaps even better, maybe let it be a first PoC for a module for a specific type of test (like common-benchmark or something). I'm not a fan of expanding the common monolith even more...

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/7406/

[Trott]

At least one benchmark using FIPS-incompatible crypto.createCipher() so skip this test on FIPS.

CI: https://ci.nodejs.org/job/node-test-pull-request/7407/

[Trott]

Landed in 8a6d44b

[MylesBorins]

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

[Trott]

This does not land cleanly in LTS.

@MylesBorins Are you sure about that? It adds a file that didn't previously exist so I'm not sure how that could be that case. git cherry-pick 8a6d44b lands cleanly for me on v6.x-staging.

[MylesBorins]

more specfiically the test fails... sorry for the rush job before

=== release test-benchmark-crypto === Path: parallel/test-benchmark-crypto module.js:471 throw err; ^ Error: Cannot find module '/Users/mborins/code/node/v6.x/benchmark/run.js' at Function.Module._resolveFilename (module.js:469:15) at Function.Module._load (module.js:417:25) at Module.runMain (module.js:604:10) at run (bootstrap_node.js:389:7) at startup (bootstrap_node.js:149:9) at bootstrap_node.js:504:3 assert.js:81 throw new assert.AssertionError({^ AssertionError: 1 === 0 at ChildProcess.child.on (/Users/mborins/code/node/v6.x/test/parallel/test-benchmark-crypto.js:34:10) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:191:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12) Command: out/Release/node /Users/mborins/code/node/v6.x/test/parallel/test-benchmark-crypto.js [00:00|% 100|+ 0|- 1]: Done 

[joyeecheung]

@MylesBorins The benchmarking tools were rewritten during 7.x period so I think all the test-benchmark-*.js PRs should not be backported to 6.x

[Trott]

more specfiically the test fails... sorry for the rush job before

@MylesBorins Guess I could have taken a moment to actually run the tests. Got it. Sorry about that! :-D