test: add hasCrypto check to test-debug-usage#12357
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do.
ContributorAuthor
danbev commented Apr 12, 2017
jasnell approved these changes Apr 12, 2017
thefourtheye approved these changes Apr 12, 2017
cjihrig approved these changes Apr 12, 2017
Member
Trott commented Apr 12, 2017
Is this because |
addaleax approved these changes Apr 14, 2017
Member
addaleax commented Apr 14, 2017
@Trott The error message in the PR description seems to indicate that you’re right. :) |
addaleax pushed a commit to addaleax/node that referenced this pull request Apr 14, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: nodejs#12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>Member
addaleax commented Apr 14, 2017
Landed in 48f780d |
ContributorAuthor
danbev commented Apr 15, 2017 via email
Sorry, I missed this one. But like @addaleax said that is the reason. ons 12 apr. 2017 kl. 21:51 skrev Rich Trott <[email protected]>: … Is this because debug is now an alias for inspect and inspect requires crypto? Or is this caused by something else? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12357 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAaY35fZXwPFGin2dqYEnasJPEOuuqN-ks5rvSs8gaJpZM4M7QBP> . |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: #12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: #12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>evanlucas pushed a commit that referenced this pull request May 2, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: #12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>MylesBorins pushed a commit that referenced this pull request May 15, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: #12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>MylesBorins pushed a commit that referenced this pull request May 18, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: #12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
When configuring --without-ssl test-debug-usage.js fails with the following error: assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) But the underlying error is the following: (node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated. Please use `node inspect` instead. internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/internal/inspect_client.js:24:16 at NativeModule.compile (bootstrap_node.js:559:7) at NativeModule.require (bootstrap_node.js:500:18) at node-inspect/lib/_inspect.js:39:5 at NativeModule.compile (bootstrap_node.js:559:7) at Function.NativeModule.require (bootstrap_node.js:500:18) assert.js:82 throw new assert.AssertionError({^ AssertionError: false == true at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5) at ChildProcess.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/common.js:461:15) at emitTwo (events.js:125:13) at ChildProcess.emit (events.js:213:7) at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12) This commit adds a check for crypto like some of the other tests do. PR-URL: nodejs/node#12357 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring --without-ssl test-debug-usage.js fails with the
following error:
But the underlying error is the following:
This commit adds a check for crypto like some of the other tests do.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test