Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: update node-inspect to v1.11.2#12363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
hybrist commented Apr 12, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
hybrist commented Apr 12, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Example for debugging a pid:
|
aqrln left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Oh, and this PR reminded me that I was interested in writing some tests and improving autocompletion of object properties, so thank you for this incidental reminder too 😄
Trott left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM if all tests pass in CI
aqrln commented Apr 12, 2017
hybrist commented Apr 12, 2017
freebsd failure: |
Trott commented Apr 12, 2017
@jkrems My current guess as to what happened here: So, in brief, unrelated to this change (which shouldn't be a surprise, I suppose). I'll re-run CI and I'll also see about perhaps moving all use of |
Trott commented Apr 12, 2017
New CI is green, woot. |
mscdex commented Apr 12, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@Trott Yep, AFAIK the remaining tests still using |
hybrist commented Apr 12, 2017
@Trott Thanks for looking into this! I assumed it was something along those lines but didn't have time yet to take a look myself. |
joshgav commented Apr 14, 2017
@jkrems can we pull in nodejs/node-inspect#44 too? Thanks! |
hybrist commented Apr 14, 2017
@joshgav Done! |
addaleax commented Apr 14, 2017
addaleax commented Apr 14, 2017
Landed in 0217197 |
PR-URL: #12363 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
gibfahn commented Jun 18, 2017
Should this be backported to |
This updates the bundled
node-inspectto 1.11.2, including nodejs/node-inspect#43 which was previously cherry-picked in #11441.Highlights
node inspect -p <pid>)Compare: nodejs/node-inspect@v1.10.6...v1.11.2
Rendered Changelog
Checklist
make -j4 testandmake test-node-inspectpassAffected core subsystem(s)
deps