src: replace IsConstructCall functions with lamda#12384
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
ContributorAuthor
danbev commented Apr 13, 2017
bnoordhuis approved these changes Apr 13, 2017
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM modulo nits. Typo in commit log: s/lamda/lambda/
src/cares_wrap.cc Outdated
Member
There was a problem hiding this comment.
Only two spaces of indent and call the variable is_construct_call (or is_construct_call_callback to indicate it's a function pointer.)
ContributorAuthor
There was a problem hiding this comment.
Ah again, must remember to not use camelcase 😞 Thanks!
ContributorAuthor
danbev commented Apr 13, 2017
cjihrig approved these changes Apr 13, 2017
jasnell approved these changes Apr 13, 2017
I noticed that there are three static functions that only check if args is a construct call. This commit suggests replacing them and them with a lambda.
ContributorAuthor
danbev commented Apr 15, 2017
addaleax approved these changes Apr 15, 2017
Member
addaleax commented Apr 15, 2017
Landed in b280363 |
addaleax pushed a commit that referenced this pull request Apr 15, 2017
I noticed that there are three static functions that only check if args is a construct call. This commit suggests replacing them and them with a lambda. PR-URL: #12384 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
3 tasks
Member
gibfahn commented Jun 18, 2017
Should this be backported to |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lamda.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src