Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
test: fix parallel/test-setproctitle.js on alpine#12413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
DavidCai1111 commented Apr 14, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
vsemozhetbyt commented Apr 14, 2017
benjamingr commented Apr 14, 2017
This breaks on FreeBSD apparently: Ping @nodejs/build regarding CI failures:
https://ci.nodejs.org/job/node-test-commit-osx/9018/nodes=osx1010/console |
lpinca commented Apr 14, 2017
This shouldn't be an issue. |
gibfahn commented Apr 14, 2017
@benjamingr the xcodebuild warnings aren't an issue (see nodejs/node-gyp#1057) xcodebuild is called twice but never actually used. |
jasnell commented Apr 17, 2017
There are definite failures in CI with this that need looking at |
72b31fe to d9e2793Comparebf0798a to 85a2592Compare85a2592 to 9a78beaCompareDavidCai1111 commented Apr 19, 2017 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Updated, and CI looks good now 😃 |
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
DavidCai1111 commented Apr 21, 2017
Landed in ee0620b |
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
gibfahn commented May 16, 2017
Doesn't backport cleanly for me to v6.x, would you be willing to backport? If yes please follow the guide and raise a backport PR, if no let me know or add the |
DavidCai1111 commented May 17, 2017
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. PR-URL: nodejs#12413Fixes: nodejs#12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. Backport-PR-URL: #13072 PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Since Busybox ps does not support -p switch, using ps -o and grep instead to get the process title and then check it. Backport-PR-URL: #13072 PR-URL: #12413Fixes: #12399 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Fixes: #12399
As mentioned in the ref issue, since Busybox
psdoes not support-pswitch, usingps -oandgrepinstead to get the process title and then check it.The
titlevariable in this test script was also renamed from'testme'to'test', because it seems that on alpine if trying to set the process title to a string whose length is >=5 like'abcde', it will become{abcde} abcdinpsoutput:Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test