benchmark: improve cli error message#12421
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joyeecheung approved these changes Apr 15, 2017
thefourtheye approved these changes Apr 15, 2017
aqrln approved these changes Apr 15, 2017
benjamingr approved these changes Apr 15, 2017
benchmark/_cli.js Outdated
Member
There was a problem hiding this comment.
Maybe I'd add "in the current folder", but I don't run this often enough anyway.
ContributorAuthor
There was a problem hiding this comment.
That would be confusing IMHO. The CLI searches all of the benchmark/ subdirectories for benchmarks specified on the command line. It never searches the current working directory.
cjihrig approved these changes Apr 15, 2017
jseijas approved these changes Apr 16, 2017
When no matching benchmark files are found, a more sensible error is shown now.
mscdexforce-pushed the benchmark-improve-error-message branch from 43926b1 to 3ca50a7Compare
ContributorAuthor
mscdex commented Apr 16, 2017
I've tweaked this a bit after I discovered there is already a benchmark count check both in run.js and _cli.js. |
mscdex commented Apr 16, 2017
| if(benchmarks.length===0){ | ||
| console.error('no benchmarks found'); | ||
| console.error('No benchmarks found'); |
ContributorAuthor
There was a problem hiding this comment.
This matches the casing used in run.js.
jasnell approved these changes Apr 17, 2017
jasnell pushed a commit that referenced this pull request Apr 17, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 17, 2017
Landed in ccdcd91 |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
When no matching benchmark files are found, a more sensible error is shown now. PR-URL: #12421 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
gibfahn commented May 16, 2017
Marking as |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no matching benchmark files are found, a more sensible error is thrown now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)