test: add crypto check to crypto-lazy-transform#12424
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 This commit add a hasCrypto check like other crypto tests do.
ContributorAuthor
danbev commented Apr 15, 2017
thefourtheye approved these changes Apr 15, 2017
richardlau approved these changes Apr 15, 2017
benjamingr approved these changes Apr 15, 2017
mscdex added crypto 
cjihrig approved these changes Apr 15, 2017
Member
Trott commented Apr 16, 2017
Maybe we need a lint rule for tests that |
Member
Trott commented Apr 16, 2017
...or we need a CI host that tests a NOde.js binary compiled without crypto... |
Member
nodejs/build#643 (just need to actually get it set up) |
jasnell approved these changes Apr 17, 2017
jasnell pushed a commit that referenced this pull request Apr 17, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 17, 2017
Landed in 1777a86 |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>evanlucas pushed a commit that referenced this pull request May 2, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
gibfahn commented May 16, 2017
Landed this on v6.x, let me know if that's a mistake. |
gibfahn pushed a commit that referenced this pull request May 16, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>MylesBorins pushed a commit that referenced this pull request May 18, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: #12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
When configuring --without-ssl test-crypto-lazy-transform-writable.js fails with the following error: ``` Path: parallel/test-crypto-lazy-transform-writable internal/util.js:83 throw new Error('Node.js is not compiled with openssl crypto support'); ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:83:11) at crypto.js:28:14 at NativeModule.compile (bootstrap_node.js:557:7) at Function.NativeModule.require (bootstrap_node.js:500:18) at Function.Module._load (module.js:446:25) at Module.require (module.js:526:17) at require (internal/module.js:19:18) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js:5:16) at Module._compile (module.js:607:30) at Object.Module._extensions..js (module.js:618:10) Command: out/Release/node /Users/danielbevenius/work/nodejs/node/test/parallel/test-crypto-lazy-transform-writable.js [01:29|% 100|+ 1461|- 1]: Done make: *** [test] Error 1 ``` This commit add a hasCrypto check like other crypto tests do. PR-URL: nodejs/node#12424 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring
--without-ssltest-crypto-lazy-transform-writable.jsfails with the following error:
This commit add a hasCrypto check like other crypto tests do.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test