zlib: remove unused declaration#12432
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Overlooked in nodejs#12366. Removing this removes a compiler warning.
addaleax added dont-land-on-v4.x lib / src 
nodejs-github-bot added c++ 2 tasks
bnoordhuis approved these changes Apr 15, 2017
benjamingr approved these changes Apr 15, 2017
MemberAuthor
addaleax commented Apr 15, 2017
cjihrig approved these changes Apr 15, 2017
richardlau approved these changes Apr 15, 2017
gibfahn approved these changes Apr 16, 2017
MemberAuthor
addaleax commented Apr 16, 2017
Landed in ea01cd7 |
addaleax added a commit that referenced this pull request Apr 16, 2017
Overlooked in #12366. Removing this removes a compiler warning. PR-URL: #12432 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlooked in #12366. Removing this
removes a compiler warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/zlib
Also trivial enough that I would say this doesn’t need to wait 48 hours.