url: update WHATWG URL parser to latest spec#12523
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ MemberAuthor
TimothyGu commented Apr 19, 2017
Member
jasnell commented Apr 19, 2017
FYI: Once this lands, and we can verify that we're fully spec compliant, I want to open a PR that moves the WHATWG URL out of Experimental status. |
jasnell approved these changes Apr 19, 2017
lib/internal/url.js Outdated
Member
There was a problem hiding this comment.
Perhaps Symbol('cannot-have-username-password-port') to remain consistent with the other symbols?
mscdex reviewed Apr 19, 2017
lib/internal/url.js Outdated
Contributor
There was a problem hiding this comment.
Perhaps host.length === 0 might be better/faster?
MemberAuthor
There was a problem hiding this comment.
The spec says "if its host is null or the empty string" so it'll be clearer this way, and no, it's not faster in my tests.
MemberAuthor
TimothyGu commented Apr 19, 2017
Sounds good to me. Will this for v8.x? |
Member
jasnell commented Apr 19, 2017
Hopefully we can do it in time for 8.0.0 |
MemberAuthor
TimothyGu commented Apr 20, 2017
@jasnell nit fixed. |
Contributor
watilde commented Apr 20, 2017
Great work! Can you also update |
TimothyGuforce-pushed the url-perc-nonspecial branch 2 times, most recently from 6257d18 to 750f452CompareMemberAuthor
@watilde, done. That actually made me notice a few bugs that were in the initial implementation, thanks! 👏 @jasnell I'd like you to take a look at this again, especially 3f53f8038fa676618db6f8169f93ba53aeaebc0c which changes how the JS-C++ layer works right now. New CI: https://ci.nodejs.org/job/node-test-pull-request/7559/ |
Member
jasnell commented Apr 20, 2017
Ok, I'll take a look in detail shortly |
watilde approved these changes Apr 20, 2017
joyeecheung approved these changes Apr 21, 2017
jasnell approved these changes Apr 21, 2017
3 tasks
TimothyGuforce-pushed the url-perc-nonspecial branch from 750f452 to 7c0704dCompare- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: nodejs#12523Fixes: nodejs#10608Fixes: nodejs#10634 Refs: whatwg/url#185 Refs: whatwg/url#225 Refs: whatwg/url#224 Refs: whatwg/url#218 Refs: whatwg/url#243 Refs: whatwg/url#260 Refs: whatwg/url#268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
TimothyGuforce-pushed the url-perc-nonspecial branch from 7c0704d to e0530f1CompareMemberAuthor
TimothyGu commented Apr 23, 2017
Also implemented whatwg/url#260. One more CI: https://ci.nodejs.org/job/node-test-pull-request/7622/ |
watilde approved these changes Apr 24, 2017
MemberAuthor
TimothyGu commented Apr 24, 2017
Landed in b2870a4. |
TimothyGu added a commit that referenced this pull request Apr 24, 2017
- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: #12523Fixes: #10608Fixes: #10634 Refs: whatwg/url#185 Refs: whatwg/url#225 Refs: whatwg/url#224 Refs: whatwg/url#218 Refs: whatwg/url#243 Refs: whatwg/url#260 Refs: whatwg/url#268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: #12523Fixes: #10608Fixes: #10634 Refs: whatwg/url#185 Refs: whatwg/url#225 Refs: whatwg/url#224 Refs: whatwg/url#218 Refs: whatwg/url#243 Refs: whatwg/url#260 Refs: whatwg/url#268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: #12523Fixes: #10608Fixes: #10634 Refs: whatwg/url#185 Refs: whatwg/url#225 Refs: whatwg/url#224 Refs: whatwg/url#218 Refs: whatwg/url#243 Refs: whatwg/url#260 Refs: whatwg/url#268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
- Update to spec - Add opaque hosts - File state did not correctly deal with lack of base URL - Cleanup API for file and non-special URLs - Allow % and IPv6 addresses in non-special URL hosts - Use specific names for percent-encode sets - Add empty host concept for file and non-special URLs - Clarify IPv6 serializer - Fix existing mistakes - Add missing ':' to forbidden host code point list. - Correct IPv4 parser empty label behavior - Maintain type equivalence in URLContext with spec - scheme, username, and password should always be strings - host, port, query, and fragment may be strings or null - Align scheme state more closely with the spec - Make sure the `special` variable is always synced with URL_FLAG_SPECIAL. PR-URL: #12523Fixes: #10608Fixes: #10634 Refs: whatwg/url#185 Refs: whatwg/url#225 Refs: whatwg/url#224 Refs: whatwg/url#218 Refs: whatwg/url#243 Refs: whatwg/url#260 Refs: whatwg/url#268 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following (non-editorial) spec changes are implemented in this PR:
I had to squash the four spec updates into one commit, since some of them overlap with one another, making it difficult to separate atomic changes.
This also enables all tests in
url-tests.js, which means that our implementation will be fully spec-compliant after this PR. 🎉Fixes: #10608
Fixes: #10634
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url