module: correcting comment spelling#12528
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the module 
jseijas approved these changes Apr 20, 2017
lib/module.js Outdated
Contributor
There was a problem hiding this comment.
I am not exactly sure what this comment actually means, but shouldn't this also be drive then?
ContributorAuthor
There was a problem hiding this comment.
I went back and forth a few times on the meaning on the sentence. In the end I thought best to just correct the spelling mistake incase I was wrong. But I can change it to parse drive name if that is the consensus.
Contributor
There was a problem hiding this comment.
Yes, I think it should be safe to correct this instance as well.
benjamingr approved these changes Apr 20, 2017
A minor typo in comments, no logic changes.
WORMSSforce-pushed the patch-spelling-mistake branch from 37b057c to 1ddbeecCompare
thefourtheye approved these changes Apr 20, 2017
jasnell approved these changes Apr 20, 2017
cjihrig approved these changes Apr 20, 2017
DavidCai1111 approved these changes Apr 21, 2017
Contributor
whitlockjc commented Apr 21, 2017
LGTM |
jasnell pushed a commit that referenced this pull request Apr 24, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Member
jasnell commented Apr 24, 2017
landed in 26047c3 |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
gibfahn pushed a commit that referenced this pull request May 16, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
A minor typo in comments, no logic changes. PR-URL: #12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
A minor typo in comments, no logic changes. PR-URL: nodejs/node#12528 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Cai <[email protected]> Reviewed-By: Jeremy Whitlock <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor spelling mistake, no logic changes.
Checklist
Affected core subsystem(s)
module (only comment)