src: replace IsConstructCalls with lambda#12533
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice.
nodejs-github-bot added the c++ 
ContributorAuthor
danbev commented Apr 20, 2017
Member
bnoordhuis commented Apr 20, 2017
stream_base.h is not a public header file, don't let anyone tell you otherwise. |
ContributorAuthor
danbev commented Apr 20, 2017
Oh perfect, I'll remove the functions instead. Thanks |
ContributorAuthor
danbev commented Apr 20, 2017
bnoordhuis approved these changes Apr 20, 2017
cjihrig approved these changes Apr 20, 2017
benjamingr approved these changes Apr 20, 2017
jasnell approved these changes Apr 20, 2017
addaleax added the lib / src 
addaleax approved these changes Apr 20, 2017
danbev added a commit to danbev/node that referenced this pull request Apr 24, 2017
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice. PR-URL: nodejs#12533 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
ContributorAuthor
danbev commented Apr 24, 2017
Landed in 8eb7790 |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice. PR-URL: #12533 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice. PR-URL: #12533 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
I've added a deprecation notice as the functions are public, but not sure if this is correct or the format of the deprecation notice. PR-URL: #12533 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn added baking-for-lts 
Member
gibfahn commented May 16, 2017
Should this land in v6.x? |
MylesBorins removed the baking-for-lts Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src