src: remove TODO about uv errno removal#12536
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit attempts to take care of a TODO reported in issue 4641. I'm not sure if just removing errno is an option, as there might be code that is depending on this errno being availble. If it cannot be removed perhaps the TODO can. Hopefully feedback on this commit will sort that out. Refs: nodejs#4641
nodejs-github-bot added the c++ 
ContributorAuthor
danbev commented Apr 20, 2017
cjihrig added the semver-major 
Contributor
Fishrock123 commented Apr 20, 2017
This is documented publicly here, and definitely used in the wild. -1 on removing it, it is useful. |
Contributor
cjihrig commented Apr 20, 2017
If we don't remove it, let's get rid of that TODO :-) |
Member
jasnell commented Apr 20, 2017
Yeah, let's definitely not remove it. There are several uses of it that I'm aware of that would cause significant breakage. |
ContributorAuthor
danbev commented Apr 20, 2017
@Fishrock123@jasnell I suspected this would be the case. Can we remove the TODO like @cjihrig mentioned? |
This reverts commit fe0b8d9.
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion.
cjihrig approved these changes Apr 20, 2017
addaleax approved these changes Apr 21, 2017
jasnell approved these changes Apr 21, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
This should not need to wait the 48 hours to land
jasnell pushed a commit that referenced this pull request Apr 21, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 21, 2017
Landed in bde26a6 |
sam-github removed the semver-major 
Member
I think this is no longer |
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request May 16, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: nodejs/node#12536 Ref: nodejs/node#4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion.
Refs: #4641
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src