src: remove erroneous dot

[MylesBorins]

This got accidentally added when landing original commit

[MylesBorins]

@nodejs/collaborators can we get some v quick LGTM's on this so we can unbreak master

[jasnell]

fyi.. there's a linting error in there also #12625

[mscdex]

LGTM

[MylesBorins]

@jasnell I'll run CI but I believe I got the linting error in here. should trump #12625

[seishun]

How about "extraneous" instead of "erroneous"?

[MylesBorins]

https://ci.nodejs.org/job/node-test-linter/8519/

[MylesBorins]

Linter is green, updated commit message as per @seishun's request

[MylesBorins]

landed in 9cc39ff

[MylesBorins]

I'm going to opt to manually fix in the backports rather than float both patches

[refack]

I'm going to opt to manually fix in the backports rather than float both patches

🏁(me raising my "nudnik" flag)
So why did this go into master in the first place, and not directly into v6.x-staging?
Master was green before #12540. just for explicitly?

[MylesBorins]

@refack obviously there was something going on without this header. Makes sense to land to master and then backport. The failing was due to me landing it improperly... which occasionally happens. We fixed it in less than an hour, which is pretty reasonable imho.

[jasnell]

We always land changes in master first unless the code being changed is a specific bug in code that no longer exists in master.

[refack]

@refack obviously there was something going on without this header. Makes sense to land to master and then backport. The failing was due to me landing it improperly... which occasionally happens. We fixed it in less than an hour, which is pretty reasonable imho.

@MylesBorins
No critique on the bad land, and fix. Great work!
I'm asking about #12540. obviously there was something going on without this header is what I wanted to know. Thank you!

We always land changes in master first unless the code being changed is a specific bug in code that no longer exists in master.

@jasnell IMHO This was a borderline case, but I defer to @MylesBorins's reasoning.

[refack]

Friends, do you think this should be documented?
is you add a new macro or use a new external function, make sure you include the header file explicitly in the file you are editing. This makes sure your change is independent of previous changes, and makes it easier to backport

[jasnell]

@refack ... a separate discussion issue would be better for that as it's not relevant to this specific PR

[refack]

Will do.
Just had to do a brain dump, and wanted to feel the wind's direction...