refactor http.get expectedCount with common.mustCall#12668
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
vsemozhetbyt commented Apr 26, 2017
Linter: It seems these variables are not needed anymore. |
aqrln reviewed Apr 26, 2017
test/parallel/test-https-strict.js Outdated
Contributor
There was a problem hiding this comment.
You should probably remove expectResponseCount usages too.
mscdex added http 
ContributorAuthor
weewey commented Apr 26, 2017
missed out on removing the variables. I have removed expectResponseCount and responseCount. |
Contributor
vsemozhetbyt commented Apr 26, 2017
hiroppy approved these changes Apr 27, 2017
jasnell approved these changes Apr 27, 2017
Member
Trott commented Apr 27, 2017
Based on email conversation with @weewey, I believe the third commit with changes to |
ContributorAuthor
weewey commented Apr 27, 2017
yes @Trott I committed the changes in the same branch, as a result the commit was appended. |
ContributorAuthor
weewey commented Apr 28, 2017
@Trott removed. |
Member
Trott commented Apr 28, 2017
jasnell pushed a commit that referenced this pull request Apr 28, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 28, 2017
Landed in f11d4a1 |
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this pull request May 2, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
gibfahn commented May 15, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor http.get expectedCount with common.mustCall
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)