src: add --napi-modules to whitelist#12733
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules.
nodejs-github-bot added the c++ 
cjihrig approved these changes Apr 28, 2017
richardlau approved these changes Apr 28, 2017
gibfahn approved these changes Apr 29, 2017
benjamingr approved these changes Apr 29, 2017
jasnell approved these changes Apr 29, 2017
MemberAuthor
mhdawson commented May 1, 2017
addaleax approved these changes May 3, 2017
Member
addaleax commented May 3, 2017
Landed in 21653b6 |
addaleax pushed a commit that referenced this pull request May 3, 2017
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules. PR-URL: #12733 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules. PR-URL: nodejs#12733 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
3 tasks
This was referenced May 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --napi-modules to whitelist for NODE_OPTIONS
as its needed so that we can run the tests that
come along with native modules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
core