meta: fix nits in README.md collaborators list#12866
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vsemozhetbyt added the meta 
ContributorAuthor
vsemozhetbyt commented May 5, 2017
@imran-iq Does your e-mail remain the same? |
lpinca approved these changes May 6, 2017
addaleax approved these changes May 6, 2017
README.md Outdated
Member
There was a problem hiding this comment.
I think you might want to re-order these alphabetically :)
gibfahn approved these changes May 6, 2017
jasnell approved these changes May 7, 2017
ContributorAuthor
vsemozhetbyt commented May 8, 2017
I am not sure to land this without @Fishrock123, @Qard, @imran-iq showing up. |
Member
Qard commented May 8, 2017
I'm happy either way on casing of my name. 👍 |
Member
gibfahn commented May 8, 2017
I think this is probably fine to land. |
ContributorAuthor
Landed in: dd06246 |
vsemozhetbyt added a commit that referenced this pull request May 8, 2017
PR-URL: #12866Fixes: #12865 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
PR-URL: nodejs#12866Fixes: nodejs#12865 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
PR-URL: #12866Fixes: #12865 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #12866Fixes: #12865 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
meta
Fixes: #12865
cc @Fishrock123, @Qard, @imran-iq