test: add skipIfInspectorDisabled to debugger-pid#12882
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently this test will fail if node was configured --without-ssl.
ContributorAuthor
danbev commented May 7, 2017
refack approved these changes May 7, 2017
cjihrig approved these changes May 8, 2017
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM. You could move this check right below the require('../common'); line, but it's not necessary.
thefourtheye approved these changes May 8, 2017
ContributorAuthor
danbev commented May 9, 2017
Sounds good, I'll move it. Thanks. |
danbev added a commit to danbev/node that referenced this pull request May 9, 2017
Currently this test will fail if node was configured --without-ssl. PR-URL: nodejs#12882 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
ContributorAuthor
danbev commented May 9, 2017
Landed in f72376d |
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Currently this test will fail if node was configured --without-ssl. PR-URL: nodejs#12882 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
3 tasks
Member
gibfahn commented Jun 20, 2017
Depends on #11631 |
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this test will fail if node was configured --without-ssl.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test