lib: remove useless default caught#12884
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
addaleax approved these changes May 7, 2017
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
LGTM, but is “unless” in the commit message a typo?
ContributorAuthor
JacksonTian commented May 7, 2017
Thanks @addaleax , let me fix it. |
The variable caught's value is undefined, so the '|| caught' is useless.
JacksonTian changed the title 
Contributor
mscdex commented May 7, 2017
refack approved these changes May 7, 2017
cjihrig approved these changes May 8, 2017
lpinca approved these changes May 8, 2017
thefourtheye approved these changes May 8, 2017
ronkorving approved these changes May 9, 2017
danbev approved these changes May 9, 2017
gibfahn approved these changes May 9, 2017
targos approved these changes May 9, 2017
jasnell approved these changes May 9, 2017
jasnell pushed a commit that referenced this pull request May 9, 2017
The variable caught's value is undefined, so the '|| caught' is useless. PR-URL: #12884 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented May 9, 2017
Landed in 824fb49 |
Member
jasnell commented May 9, 2017
(It's funny how many sign offs we can get on these small changes ;-) ...) |
Member
|
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
The variable caught's value is undefined, so the '|| caught' is useless. PR-URL: nodejs#12884 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
The variable caught's value is undefined, so the '|| caught' is useless. PR-URL: #12884 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
The variable caught's value is undefined, so the '|| caught' is useless. PR-URL: #12884 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable caught's value is undefined, so the '|| caught' is
useless.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib/internel/bootstrap_node