test: fix test-fs-symlink-dir-junction-relative#129
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* The test no longer relies on being invoked from a particular working directory to function properly. * fs.symlink() and fs.symlinkSync() are both tested. * The test now cleans up after itself. This commit fixesnodejs#126 R=@bnoordhuis
Member
bnoordhuis commented Dec 9, 2014
I would perhaps drop the console.log() statements on the premise that a passing test is a quiet test - but LGTM. |
piscisaureus added a commit that referenced this pull request Dec 9, 2014
* The test no longer relies on being invoked from a particular working directory to function properly. * fs.symlink() and fs.symlinkSync() are both tested. * The test now cleans up after itself. This commit fixes#126 PR-URL: #129 Reviewed-By: Ben Noordhuis <[email protected]>
ContributorAuthor
piscisaureus commented Dec 9, 2014
|
boingoing pushed a commit to boingoing/node that referenced this pull request Apr 6, 2017
* Remove napi registration code from node.cc * make napi_module_register extern "C"
This was referenced Sep 1, 2021
This was referenced Sep 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working directory to function properly.
This commit fixes#126
R=@bnoordhuis