test: replace port in https address family test#12915
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented May 9, 2017
thefourtheye approved these changes May 9, 2017
hiroppy approved these changes May 9, 2017
gibfahn approved these changes May 9, 2017
lpinca approved these changes May 9, 2017
cjihrig approved these changes May 9, 2017
Replaced common.PORT with zero in the following test. test-https-connect-address-family.js Refs: #12376
arturgvieira-zz changed the title 
Member
lpinca commented May 12, 2017
lpinca pushed a commit to lpinca/node that referenced this pull request May 12, 2017
Remove common.PORT from test-https-connect-address-family to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: nodejs#12915 Ref: nodejs#12376 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
lpinca commented May 12, 2017
Landed in 56812c8. |
64 tasks
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Remove common.PORT from test-https-connect-address-family to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: nodejs#12915 Ref: nodejs#12376 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
MylesBorins pushed a commit that referenced this pull request Jun 22, 2017
Remove common.PORT from test-https-connect-address-family to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12915 Ref: #12376 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
Remove common.PORT from test-https-connect-address-family to eliminate possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12915 Ref: #12376 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced common.PORT with zero in the following test.
test-https-connect-address-family.js
Refs: #12376
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test https