test: add common.mustCall() to NAPI exception test#12959
Closed
+2 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use `common.mustCall()` to confirm that function is invoked.
nodejs-github-bot added node-api 
cjihrig approved these changes May 11, 2017
thefourtheye approved these changes May 11, 2017
gibfahn approved these changes May 11, 2017
addaleax approved these changes May 11, 2017
BridgeAR approved these changes May 11, 2017
jasnell approved these changes May 11, 2017
MemberAuthor
Trott commented May 13, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 13, 2017
Use `common.mustCall()` to confirm that function is invoked. PR-URL: nodejs#12959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented May 13, 2017
Landed in 9516aa1 |
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Use `common.mustCall()` to confirm that function is invoked. PR-URL: nodejs#12959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
Use `common.mustCall()` to confirm that function is invoked. PR-URL: nodejs#12959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Use `common.mustCall()` to confirm that function is invoked. Backport-PR-URL: #19447 PR-URL: #12959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
common.mustCall()to confirm that function is invoked.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test