src: add/move hasCrypto checks for async tests#12968
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently when configured --without-ssl these test will fail. In test-crypto-pbkdf2.js and test-crypto-randomBytes.js the check exists but just need to be moved before the require of crypto. There was not check in test-async-wrap-uncaughtexception.js so one was added.
ContributorAuthor
danbev commented May 11, 2017
BridgeAR approved these changes May 11, 2017
gibfahn approved these changes May 11, 2017
addaleax approved these changes May 11, 2017
lpinca approved these changes May 11, 2017
lucamaraschi approved these changes May 11, 2017
thefourtheye approved these changes May 11, 2017
mscdex added the async_hooks 
cjihrig approved these changes May 11, 2017
jasnell approved these changes May 11, 2017
danbev added a commit to danbev/node that referenced this pull request May 12, 2017
Currently when configured --without-ssl these test will fail. In test-crypto-pbkdf2.js and test-crypto-randomBytes.js the check exists but just need to be moved before the require of crypto. There was no check in test-async-wrap-uncaughtexception.js so one was added. PR-URL: nodejs#12968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Luca Maraschi <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
danbev commented May 12, 2017
Landed in 9f8e030 |
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Currently when configured --without-ssl these test will fail. In test-crypto-pbkdf2.js and test-crypto-randomBytes.js the check exists but just need to be moved before the require of crypto. There was no check in test-async-wrap-uncaughtexception.js so one was added. PR-URL: nodejs#12968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Luca Maraschi <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when configured --without-ssl these test will fail. In
test-crypto-pbkdf2.js and test-crypto-randomBytes.js the check exists
but just need to be moved before the require of crypto.
There was not check in test-async-wrap-uncaughtexception.js so one was
added.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test