test: make the rest of tests path-independent#12972
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
vsemozhetbyt commented May 11, 2017
Member
Trott commented May 11, 2017
@nodejs/testing This is specifically about permitting spaces in the path, right? Might be good to make that explicit in the PR description and commit message. |
Permit spaces in paths to a Node.js executable and test scripts. Fixes: #12773
ContributorAuthor
vsemozhetbyt commented May 11, 2017
cjihrig approved these changes May 11, 2017
ContributorAuthor
vsemozhetbyt commented May 14, 2017
Landed in 945f208 |
vsemozhetbyt added a commit that referenced this pull request May 14, 2017
Permit spaces in paths to a Node.js executable and test scripts. PR-URL: #12972Fixes: #12773 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Permit spaces in paths to a Node.js executable and test scripts. PR-URL: nodejs#12972Fixes: nodejs#12773 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
Contributor
MylesBorins commented Jun 22, 2017
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land |
3 tasks
ContributorAuthor
vsemozhetbyt commented Jun 22, 2017
@MylesBorins Done: #13880 |
MylesBorins pushed a commit that referenced this pull request Jul 10, 2017
Permit spaces in paths to a Node.js executable and test scripts. PR-URL: #12972Fixes: #12773 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
Permit spaces in paths to a Node.js executable and test scripts. PR-URL: #12972Fixes: #12773 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Permit spaces in paths to a Node.js executable and test scripts.
Fixes: #12773