Skip to content

Conversation

@gibfahn
Copy link
Member

  • The V8 inspector is no longer experimental.
  • Note that building without SSL disables other features.

Refs: #12768 (comment)

Checklist
Affected core subsystem(s)

doc, build

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 11, 2017
@gibfahn
Copy link
MemberAuthor

cc/ @refack@sam-github

@refack
Copy link
Contributor

I still want --without-ssl to scream, but this is definitely a good start 👍
Ohh, if you're there --without-intl also disables inspector

@refackrefack added the tools Issues and PRs related to the tools directory. label May 11, 2017
configure Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comma after inspector

- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: nodejs#12978 Refs: nodejs#12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@gibfahn
Copy link
MemberAuthor

refack pushed a commit to refack/node that referenced this pull request May 26, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: nodejs#12978 Refs: nodejs#12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@refack
Copy link
Contributor

Landed in e5e581c

@refackrefack closed this May 26, 2017
@gibfahngibfahn deleted the config-help branch May 26, 2017 18:30
jasnell pushed a commit that referenced this pull request May 28, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: #12978 Refs: #12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@jasnelljasnell mentioned this pull request May 28, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: #12978 Refs: #12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@gibfahn@refack@jasnell@thefourtheye@Trott@lpinca@cjihrig@richardlau@MylesBorins@nodejs-github-bot