test: add not-called check to heap-profiler test#12985
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add `common.mustNotCall()` to make sure there aren't any strange shenanians in the C++ test that would cause the function to execute when it shouldn't.
Trott added addons 
nodejs-github-bot added addons 
cjihrig approved these changes May 11, 2017
jasnell approved these changes May 12, 2017
refack approved these changes May 12, 2017
lpinca approved these changes May 12, 2017
MemberAuthor
Trott commented May 13, 2017
MemberAuthor
CI looks like it was having multiple difficulties with builds unrelated to this change. Let's run it again. |
Contributor
refack commented May 14, 2017
Windows fail is a flake. |
Trott added a commit to Trott/io.js that referenced this pull request May 15, 2017
Add `common.mustNotCall()` to make sure there aren't any strange shenanians in the C++ test that would cause the function to execute when it shouldn't. PR-URL: nodejs#12985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented May 15, 2017
Landed in b7bc09f |
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Add `common.mustNotCall()` to make sure there aren't any strange shenanians in the C++ test that would cause the function to execute when it shouldn't. PR-URL: nodejs#12985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
3 tasks
MylesBorins pushed a commit that referenced this pull request Jun 22, 2017
Add `common.mustNotCall()` to make sure there aren't any strange shenanians in the C++ test that would cause the function to execute when it shouldn't. PR-URL: #12985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
Add `common.mustNotCall()` to make sure there aren't any strange shenanians in the C++ test that would cause the function to execute when it shouldn't. PR-URL: #12985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
common.mustNotCall()to make sure there aren't any strangeshenanians in the C++ test that would cause the function to execute when
it shouldn't.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test addons