test:refactor test-https-set-timeout-server#13032
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Add common.mustCall() for error handlers. * Alphabetize modules
Trott added https 
lpinca approved these changes May 15, 2017
cjihrig approved these changes May 15, 2017
refack approved these changes May 15, 2017
jasnell approved these changes May 15, 2017
MemberAuthor
Trott commented May 19, 2017
aqrln approved these changes May 19, 2017
Contributor
aqrln left a comment
aqrln left a comment There was a problem hiding this comment.
The commit message should probably have a space after the colon.
Trott added a commit to Trott/io.js that referenced this pull request May 20, 2017
* Add common.mustCall() for error handlers. * Alphabetize modules PR-URL: nodejs#13032 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
MemberAuthor
Trott commented May 20, 2017
3 tasks
Contributor
MylesBorins commented Jul 17, 2017
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test https