Skip to content

test: confirm callback is invoked in fs test#13132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: confirm callback is invoked in fs test #13132

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented May 20, 2017

Use common.mustCall() in test-fs-makeStatsCallback to confirm that the
callback is invoked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

@Trott
test: confirm callback is invoked in fs test
e73d090
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked.
@TrottTrott added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels May 20, 2017
mhdawson
mhdawson approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented May 23, 2017

CI run: https://ci.nodejs.org/job/node-test-pull-request/8252/

@addaleax
Copy link
Member

addaleax commented May 23, 2017

Landed in 7c12d12

addaleax pushed a commit that referenced this pull request May 23, 2017
@Trott@addaleax
test: confirm callback is invoked in fs test
7c12d12
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request May 24, 2017
@Trott@jasnell
test: confirm callback is invoked in fs test
076bcc9
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request May 28, 2017
@Trott@jasnell
test: confirm callback is invoked in fs test
110a3b2
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@jasnelljasnell mentioned this pull request May 28, 2017
Closed
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@Trott@MylesBorins
test: confirm callback is invoked in fs test
548aba4
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott@MylesBorins
test: confirm callback is invoked in fs test
4a3e089
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@TrottTrott deleted the fsmake branch January 13, 2022 22:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

+2 more reviewers

@thefourtheyethefourtheyethefourtheye approved these changes

@aqrlnaqrlnaqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@mhdawson@addaleax@jasnell@thefourtheye@lpinca@cjihrig@aqrln@MylesBorins