test: add override to ServerDone function#13166
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone(){^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning.
nodejs-github-bot added dont-land-on-v4.x inspector 
ContributorAuthor
danbev commented May 23, 2017
cjihrig approved these changes May 23, 2017
refack approved these changes May 23, 2017
jasnell approved these changes May 23, 2017
addaleax approved these changes May 25, 2017
Member
addaleax commented May 25, 2017
Landed in 25ade76 |
addaleax pushed a commit that referenced this pull request May 25, 2017
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone(){^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: #13166 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>jasnell pushed a commit that referenced this pull request May 25, 2017
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone(){^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: #13166 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>jasnell pushed a commit that referenced this pull request May 28, 2017
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone(){^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: #13166 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
3 tasks
Contributor
MylesBorins commented Jul 17, 2017
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This was referenced Dec 1, 2023
This was referenced May 14, 2024
This was referenced May 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following compiler warning is displayed when building:
This commit marks ServerDone with override to get rid of the warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test