Skip to content

async_hooks: rename AsyncEvent to AsyncResource#13192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

async_hooks: rename AsyncEvent to AsyncResource #13192

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented May 24, 2017

AsyncEvent is not a good name given its semantics.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

@addaleax
async_hooks: rename AsyncEvent to AsyncResource
982b385
`AsyncEvent` is not a good name given its semantics.
@addaleaxaddaleax added async_hooks Issues and PRs related to the async hooks subsystem. dont-land-on-v4.x labels May 24, 2017
@addaleaxaddaleax added this to the 8.0.0 milestone May 24, 2017
@nodejs-github-botnodejs-github-bot added the async_hooks Issues and PRs related to the async hooks subsystem. label May 24, 2017
@addaleaxaddaleax mentioned this pull request May 24, 2017
Closed
4 tasks
AndreasMadsen
AndreasMadsen approved these changes May 24, 2017
View reviewed changes
Copy link
Member

@AndreasMadsenAndreasMadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is green.

CI: https://ci.nodejs.org/job/node-test-pull-request/8276/

Fishrock123
Fishrock123 approved these changes May 24, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@addaleax
Copy link
MemberAuthor

addaleax commented May 26, 2017

Landed in 90dee89

@addaleaxaddaleax deleted the asyncevent-to-asyncresource branch May 26, 2017 15:42
addaleax added a commit that referenced this pull request May 26, 2017
@addaleax
async_hooks: rename AsyncEvent to AsyncResource
90dee89
`AsyncEvent` is not a good name given its semantics. PR-URL: #13192 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request May 28, 2017
@addaleax@jasnell
async_hooks: rename AsyncEvent to AsyncResource
3863c3a
`AsyncEvent` is not a good name given its semantics. PR-URL: #13192 Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@jasnelljasnell mentioned this pull request May 28, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@AndreasMadsenAndreasMadsenAndreasMadsen approved these changes

@Fishrock123Fishrock123Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@jasnell@AndreasMadsen@Fishrock123@cjihrig@nodejs-github-bot